Josh Stone comments

Results 817 comments of


                                            Josh Stone

Shuffling an IndexSet

Since #244, you can write something like `map.sort_by_cached_key(|_, _| fastrand::u64(..))`.

Feature request: `.values_mut_range(idx..)`

> Maybe `bindings.values_mut_range(len_before..).for_each(..)` would be nicer? Now that we have `map::Slice`, you can write this like `bindings[len_before..].values_mut()`.

ACP: `PathBuf::has_dir_suffix`

Similarly, `make_dir` sounds to me like it's going to actually call `mkdir`.

ACP: `PathBuf::has_dir_suffix`

> * The result will always have `file_name() == None` I don't think that works like you expect either -- the examples on that method include "/usr/bin/" returning `Some("bin")`. How...

Create iterator function in std libs: split_item_mut()

Does this make sense for many iterators? It seems more like a new variant of the slice-splitting methods, if it returned `(&mut [T], &mut T, &mut [T])` as mentioned in...

re-export num_traits

I don't love the idea of re-exporting *all* of `num-traits`, as there's a lot that has nothing to do with this crate, but that puts it all in the public...

Add bitwise operations with primitive ints

I still think the mixed signed-ness is too confusing, let's drop that.

Carry only single word in multiplication

Closing for inactivity; please feel free to reopen when ready.

Is it normal that to_string() for bigint takes so much(8-10 mins)?

I think a type parameter would be *way* too intrusive. I also think that defaulting to an abbreviated form would be a surprising change for the "unaware" on the other...

Is it normal that to_string() for bigint takes so much(8-10 mins)?

Let's maybe start with an abbreviated form, and leave conditionals external for now. I fear that might still be somewhat slow to find the upper decimal digits, but maybe it...