Josh Stone

Results 817 comments of Josh Stone

It seems ready to me. Maybe @yungcomputerchair or @GrigorenkoPV can try writing a [stabilization report](https://std-dev-guide.rust-lang.org/development/stabilization.html#stabilization-report)? (I don't think I can start the actual FCP since I'm not part of the...

You could also build from the dist-src tarball, which already has all submodules and vendored crates included: e.g. https://static.rust-lang.org/dist/2024-05-10/rustc-nightly-src.tar.xz Also set `[build] vendor = true` in your root `config.toml`. (the...

> Can you please share dist-src tarballs for 1.77, 1.78 ? Those are available directly in the `dist/` path, like: https://static.rust-lang.org/dist/rustc-1.78.0-src.tar.xz

Please resolve the `mingw-check` failure. @rustbot author

The feature was stabilized in rust-lang/rust#108668, headed for Rust 1.71. Does this PR need updating for that? At the very least, we should not need the `feature(debugger_visualizer)` attribute anymore, but...

It's a bad API to have allowed `BigUint` at all -- please use `BigInt` here.

You could wrap `BigUint` in a type that does modular `Sub`, so it never goes negative. The conversions are not so bad though - `From for BigInt` is very cheap,...

> Do you have a standalone repo for `steam-runtime-launch-client` where I can play with it? FWIW, I found it here: https://gitlab.steamos.cloud/steamrt/steam-runtime-tools/-/blob/main/bin/launch-client.c

I am on that team -- @KodrAus if the `master` branch is ready to publish 1.5.0, I can do that for you.

`rayon-cond` is runtime-conditional, not at compilation time. The idea was that it might help with dynamic decisions about parallelism, but if you want a static choice, `cfg` would be a...