num-bigint icon indicating copy to clipboard operation
num-bigint copied to clipboard

Published 20 hours ago • verified publisher icon rust-num

Carry only single word in multiplication

Open calebsander opened this issue 2 years ago • 1 comments

The carry from a multiply or a multiply-accumulate is a single word, so update the functions to clarify that. Use a temporary double word for the computation. And rename "acc" to "carry" to distinguish from the accumulator.

Also use multiply instead of multiply-accumulate for string conversions.

And remove an unnecessary mask in get_lo().

calebsander avatar Jul 31 '22 20:07 calebsander

Have you run benchmarks for this change? It has been pretty sensitive in the past, whether this ultimately coaxes good behavior out of LLVM.

cuviper avatar Aug 03 '22 23:08 cuviper

Closing for inactivity; please feel free to reopen when ready.

cuviper avatar Feb 11 '23 01:02 cuviper