Josh Stone
Josh Stone
@bors r=BoxyUwU rollup
I've also been thinking about dates to find out which of my dependencies haven't been updated in a long time, as a proxy for "possibly unmaintained". I suppose the static...
The lock file is completely irrelevant to any dependents of this crate. The downstream root crate/workspace will have their own lock file independent of whatever you have here. It only...
The 1.x series was a bit messy with the std/no_std support, and std is required to get a default `S` parameter. Roughly: - 1.0 always required `std`, so there was...
Closing because I don't think there's anything we can do to fix 1.x. Feel free to ask any followup questions though!
I have no experience with kani, so I don't know how burdensome this would be. If it can be added without adding much maintenance overhead, that's probably fine, especially if...
> I thought this was a bug, but perhaps I'm misunderstanding the meaning of `Sign::NoSign`. Is this meant to signify a value with zero magnitude? Yes, and so the input...
Those nested functions do check their conditions right away: https://github.com/rust-num/num-bigint/blob/e9b204cf5abd91dda241a921444cce4abcc6f885/src/bigint/power.rs#L71-L79 https://github.com/rust-num/num-bigint/blob/e9b204cf5abd91dda241a921444cce4abcc6f885/src/biguint/power.rs#L134-L138 > to avoid possible panic. How would we *avoid* the panic? These functions have no other way to communicate...
I see that you have opened a few similar issues on different projects. In general, it is not considered a problem in Rust if a function panics when documented preconditions...
At minimum, this has the same hazards as `new_raw`, as these could be used to create non-reduced values and/or non-positive denominators. What is the use case? (Ideally some real case...