Lewis

Results 93 comments of Lewis

No sir, not that I know of, hence the conflict. Regarding "JS and CSS at same import", I would not recommend that! You can import from "." with postcss-import by...

Ideally the identifier would just be run through native Node resolution to get the entry point and prefer the `style` field in nearest package.json (else fall back to entry point...

@mprobst, `util` is a Node builtin and does not exist in `node_modules/`. This does not work as expected, as these cannot be flagged as externs and apparently only work if...

@mistersomebody, could you please upload your project directory to a repo so that I can replicate the hack? Your creativity is much appreciated.

> Alternately, we require all @define values to be globally unique but that would eventually going to cause problems. That should be fine - they're all *defined* in a globally...

I've finally managed to find a solution to this that will not throw a `goog is not defined` VM error at runtime, will not throw a compiler error for overriding...

I left a hacky, but working solution above if you want to actually use `@define` - you just need to use `goog.define('fully.qualified.name', ...)`, where you have to use a fully...

The compiler does not understand that `this.quaternion` is instantiated in the constructor. If you remove `Object.defineProperties(...)` and use `this.quaternion = quaternion`, this warning will go away. Admittedly, it would be...

Yeah, I think we have had issues about this before, for this exact library and this exact situation. @lauraharker, @brad4d, does this issue (with the `Object.defineProperties` conflicting with ThreeJS `Quaternion`...

Hey @rishipal, I saw your comment about errors, I did not see any when I submitted the PR. Apologies for the delay, I have not had much free time to...