Colin Snover

> First, it doesn't really make sense for this attribute to be allowed on unit structs since they cannot have generic parameters, but struct and unit struct share the same...

Oh, and for `T::Args` I think it would need to be: 1. If no args/args_raw, specify `for

Thanks for working on this! I will have a closer look at the code in a bit to ensure I have a better shared context for the discussion, but just...

Sorry about the noise from CI, I’ve rebased the branch to fix the failures and am going to see how far I can get on reviews tonight.

The argument for avoiding redundancy is persuasive, it just seems to me like a weird way to do it because a generic parameter and a field aren’t one-to-one, so when...

I am currently over-encumbered and don’t have a timeline for when I will be able to review next. Maybe someone else can peek? ? ? ????? ? > P.S. I...

Thanks for your report! This appears to happen only when using the non-derive macros, which is confusing since `cargo expand` output appears to be identical. I am not sure I...

Hi, sorry for the delay in looking at this. This appears to be a redundant implementation of combining `take_seek` with `until_eof`. Outside of the unresolved discussion points in #217 regarding...

The problem here is that the structures in your example are recursive (`XmrObject` -> `XmrObjectInner` -> `OuterContainer` -> `XmrObject`) and when the Rust compiler monomorphises the `read_options` function over the...

Whoops! I didn’t notice that this was only working correctly in conjunction with PR #121, which I have been running locally. I thought it was weird that the error messages...