Colin Snover

Results 62 comments of Colin Snover

This is basically https://github.com/jam1garner/binrw/issues/17 so this issue can be closed.

Just had to figure out a bug and dumping thoughts here about things a dbg implementation probably should have beyond what is in this PR: * Show the position of...

@jdavis could you please either land this and publish a new version or mark this project as dead and not to be used? Introducing the grunt-rename task into a project...

> There's nothing I can do about it, sorry. Can you not implement the into methods on BString and forward them to the inner `bytes`? ```rust impl BString { pub...

> If you quoted the rest of that paragraph... Ugh, I’m sorry about that. I’m having one of those days. I agree that it is crappy for maintenance to have...

Hm. After looking more closely that did not actually seem to fix the problem.

According to the ES spec, when defining a new function, it is given a prototype with a `constructor` property (§13.2). This doesn’t mean a function _is_ a constructor; just like...

Where do you expect these to go? They don’t show up in details.xml in 1.5 either.

Well I added the private tag attribute in df733f7, I don’t know why the other tags are useful for at the moment though. Does the viewer actually do something with...

Since the tags were not actually in use before I would prefer to focus on functionality that used to exist but is broken, so I am going to defer this...