Colin Snover
Colin Snover
Problems 1 and 3 are still valid; 2 is probably fixed by `err_context` but I should probably double-check to be certain; I think I just fixed 7; problem 4 is...
1: #155 2: jam1garner fixed it, yay. 3: #155 4: Impossible to resolve until downcasting to a trait from dyn Any is a thing. 5/6/7: I have fixed these locally....
This was fixed by dd4fa9b4610369f7f9c2034d205563edf468a1f5.
There is now an explicit error message explaining the problem and what to do instead. Thanks for your report!
> If anyone could give some pointers on how I should track ticks in Scummvm that would be appreciated. `OSystem::getMillis` is the backend-agnostic mechanism for getting time since the program...
This is caused by [optimize access to loop targets](https://github.com/twigphp/Twig/blob/73f5ef259026a6b28f4a203ec096f491c8a94787/src/NodeVisitor/OptimizerNodeVisitor.php#L148-L150). 1. Optimizer visits ForNode and adds loop target nodes to `$this->loopsTargets`; 2. Optimizer visits the `seq` sub-node, which is a `NameExpression`...
Yes, that certainly makes more sense. Thanks for your feedback! So I guess it would be more like this?: ```diff diff --git a/vendor/twig/twig/src/NodeVisitor/OptimizerNodeVisitor.php b/vendor/twig/twig/src/NodeVisitor/OptimizerNodeVisitor.php index 9f7cae4d..f5bf6c7c 100644 --- a/vendor/twig/twig/src/NodeVisitor/OptimizerNodeVisitor.php +++...
Sorry for not doing this as a PR, I am ignorant of Twig and wasn’t expecting to actually make a working solution. I will open a PR if you want,...
It looks like I accidentally superseded this PR by not paying attention 😵💫 and writing and committing a [similar helper function](https://github.com/jam1garner/binrw/commit/6636452ff5e0ea72160e92a0eb98f4c6806970e5). The differences between the two appear to be: 1....
Sorry about the delay, this repository has been superseded by [binrw](https://github.com/jam1garner/binrw/). The reason this error occurs is because binread was created before the stabilisation of const generics so only has...