Colin Snover
Colin Snover
Sorry, I started this review yesterday and didn’t see the self-review so some of my questions are redundant :-)
@kitlith where are you at with this?
> Having difficulty applying focus to the task right now. Extremely relatable comment. Is this approach a third path that is used only by the `count` helper, or is it...
Do you know where in libmagic this is happening, or how I could trigger it? Looking at the source code it seems like debugging output is gated behind `MAGIC_DEBUG` flags...
Oops. I see `MAGIC_CHECK` flag is being used. Emitting diagnostic messages to stderr is also its intended purpose according to magic.h: ``` #define MAGIC_CHECK 0x0000040 /* Print warnings to stderr...
I agree that libmagic seems like a mess of a thing that probably started its life as an executable and only got half-abstracted out into a library. I am no...
Probably neither here nor there at this point but vscode’s built-in terminal does seem to do something weird with file descriptors that other terminals don’t that seems to be able...
Hi! I am going through and triaging old PRs. Are you still interested in working on this and would like a review? Thanks!
Hi, thanks for your report! I thought this was written already, but I guess it was just in my head (or maybe in some discussion thread somewhere). This is an...
Just to make sure I understand, this is so that a struct can have an unbounded generic type whilst still being able to derive the binrw implementation by passing the...