Claudio Ruggeri - CR-Tech

Results 29 comments of Claudio Ruggeri - CR-Tech

> How do you validate that the configuration is not "= [1,2,3]" I don't and I don't take in care of that because we use only the first parameter. Do...

> LGTM, Thanks. Thanks you, @janiversen for your patience. I learned a lot from these experiences, in case you want/need, I'm available to collaborate.

A connection point is not a device. You could have multiple devices into the same connection point when you use a serial link instead of TCP. So the connection point...

![immagine](https://github.com/user-attachments/assets/a5036cb2-8500-421a-bd56-23de1181c5d2) Considering the disclaimer, I don't think it would be a great idea, imho.

I report similar problems here: ``` navidrome[929]: time="2024-09-08T14:29:57+02:00" level=debug msg="Processing GetDevice" user=claudio navidrome[929]: time="2024-09-08T14:29:57+02:00" level=info msg="JukeboxControl request received" action=start requestId=CRH-SRV-00/0UZmCUhACt-000061 navidrome[929]: time="2024-09-08T14:29:57+02:00" level=debug msg="Processing Start action" device="Name: auto, Gain: 1.0000,...

Failure of `CI / Run tests Python 3.12 (7) (pull_request) Failing after 9m ` is not related to modbus, but to reolink integration.

> FYI I am still waiting for the second pair of eyes I can understand.. Meanwhile I'm trying to help you with the other new PR on modbus.

All the modbus changes, just to search using modbus as key. In example from change log 2025.6: ![Image](https://github.com/user-attachments/assets/f5dfbab3-107b-4a4c-a09c-b04e9c831b6d) from change log 2025.2: ![Image](https://github.com/user-attachments/assets/57da7d1d-14c1-452a-8258-ae2e04d44aff) Comparing the images, we can see that...

Init of the change log for 2025.6 ![Image](https://github.com/user-attachments/assets/a4c0a5e4-f79e-46a2-93cc-55f866d65b77) Init of the change log for 2025.2 ![Image](https://github.com/user-attachments/assets/b63f6037-4c95-4ca8-9b31-da54f2454a96)