Add list as possible values for State On/Off ModBus Switch
Breaking change
Proposed change
The PR adds the possibility to have a list of values instead of a single one for state_on field used to customize the verification value of a switch. This is useful in case a switch turned on answers with a set of values to indicates its status instead of only one.
This PR is the exact copy of the PR #123626 , erroneusly closed during rebase.
Type of change
- [ ] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [X] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
Additional information
- This PR fixes or closes issue: fixes #
- This PR is related to issue:
- Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/35053
Checklist
- [X] The code change is tested and works locally.
- [X] Local tests pass. Your PR cannot be merged unless tests pass
- [X] There is no commented out code in this PR.
- [X] I have followed the development checklist
- [X] I have followed the perfect PR recommendations
- [X] The code has been formatted using Ruff (
ruff format homeassistant tests) - [X] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [X] Documentation added/updated for www.home-assistant.io
If the code communicates with devices, web services, or third-party tools:
- [ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running:python3 -m script.hassfest. - [ ] New or updated dependencies have been added to
requirements_all.txt.
Updated by runningpython3 -m script.gen_requirements_all. - [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
To help with the load of incoming pull requests:
- [ ] I have reviewed two other open pull requests in this repository.
Here is the new PR @joostlek :)
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:
Failure of
CI / Run tests Python 3.12 (7) (pull_request) Failing after 9m is not related to modbus, but to reolink integration.
FYI I am still waiting for the second pair of eyes
FYI I am still waiting for the second pair of eyes
I can understand.. Meanwhile I'm trying to help you with the other new PR on modbus.
I saw that, awesome ❤️