core icon indicating copy to clipboard operation
core copied to clipboard

Add write_registers support for Fan Mode

Open crug80 opened this issue 1 year ago • 1 comments

Proposed change

As already possible for aother registers of the climate entity, this PR add the write_registers support also in Fan Mode. The new parameter is optional and its default value is False.

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [X] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/30838

Checklist

  • [X] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
  • [X] There is no commented out code in this PR.
  • [X] I have followed the development checklist
  • [X] I have followed the perfect PR recommendations
  • [X] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [X] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

crug80 avatar Jan 14 '24 21:01 crug80

Hey there @janiversen, mind taking a look at this pull request as it has been labeled with an integration (modbus) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of modbus can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign modbus Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant[bot] avatar Jan 14 '24 21:01 home-assistant[bot]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Jan 17 '24 10:01 home-assistant[bot]

How do you validate that the configuration is not "= [1,2,3]"

I don't and I don't take in care of that because we use only the first parameter. Do you want the same approach used for target temp validation of addresses in order to raise an error in case of list greater than 1?

crug80 avatar Jan 23 '24 13:01 crug80

Validation is all about filtering out faulty configurations so of course if the list have a wrong number of elements it needs to be signaled,

janiversen avatar Jan 23 '24 16:01 janiversen

LGTM, Thanks.

Thanks you, @janiversen for your patience. I learned a lot from these experiences, in case you want/need, I'm available to collaborate.

crug80 avatar Jan 24 '24 18:01 crug80