Christian Trott
Christian Trott
Here is a patch which does change the assignability - not promising yet that we do this. ```diff diff --git a/core/src/HIP/Kokkos_HIP_Space.hpp b/core/src/HIP/Kokkos_HIP_Space.hpp index 63590f278..287f27a85 100644 --- a/core/src/HIP/Kokkos_HIP_Space.hpp +++ b/core/src/HIP/Kokkos_HIP_Space.hpp @@...
Yeah we carry around type erased deleter functions so it deletes correct
Ok, so I did the PR and adding the proper unit test, and that test shows we do NOT enable assignment from SharedSpace to HostSpace ... So the following: ```c++...
Note that also means that the following didn't work when using Cuda UVM enforcement: ```c++ Kokkos::View a("A", N); Kokkos::View h_a = create_mirror_view(a); ```
Ok we followed up and the affected codes are able to work around the issue. Since the current behavior has been the status quo forever, including in the time we...
Hi, I think we could make a compromise here if you are willing to help maintain that part, and say that mdspan as in C++23 (i.e. mdspan, extents, layout_left, layout_right...
We will take a look.
So it looks like you are using a 2D View to index into a 3D view: that is where it goes off the rails. If we break it down into...
> Okay thanks for the explanation but in principle the loop is over `jc` and the iteration is over a contiguous part of the memory so shouldn't it vectorize it...
I looked at release dates. The GCC 10.4 is fairly new June 2022. 11.1 is April 2021, 10.1 is May 2020, 12.1 is May 22. I feel slightly uncomfortable raising...