Christian Trott
Christian Trott
It crashes even in the firs DoNotOptimize. If one defines BENCHMARK_HAS_NO_INLINE_ASSEMBLY in benchmark.h the problem goes away. So probably that should be defined for IBM XL. Trying to see what...
@j8asic can you try my PR branch? With CUDA 11.4 and Visual Studio 19 that is compiling and passing tests for me.
Fixed more issues, which popped up in VS 2022.
Just for reference with VS 2022 I started with a standard x64-MSVC config and added these: ``` -DKokkos_ENABLE_CUDA=ON -DKokkos_ENABLE_CUDA_LAMBDA=ON -DKokkos_ARCH_VOLTA70=ON -DKokkos_ENABLE_TESTS=ON -DKokkos_ENABLE_COMPILE_AS_CMAKE_LANGUAGE=ON ``` as CMAKE config args. No other editing...
For reference: the error before the fix: ``` C:\Users\ceear\Source\Repos\kokkos\core\src\Kokkos_HostSpace.hpp(268): error C2955: 'Kokkos::Impl::SharedAllocationRecord': use of class template requires template argument list ../../../core/src\impl/Kokkos_SharedAlloc.hpp(309): note: see declaration of 'Kokkos::Impl::SharedAllocationRecord' ../../../core/src\impl/Kokkos_SharedAlloc.hpp(320): note: see reference...
It actually gets renamed in #5268
We decided that we need to support stuff like this as part of a larger enhancement of sorting capabilities in Kokkos, that includes new underlying sort algorithms.
Replaces #4145 which was trying to fix #4126 See discussion in #4294
Regarding the test. I guess I can add a completely new test, its just I have to add a new executable ...
Oh and obviously I gotta fix the pthread issue.