Christian Trott
Christian Trott
Thanks! I had overlooked that. That said I am not sure it's the best way to go about this. Now the tests never take the code path where the preconditions...
Also I am waiting for a second review to finish (should happen latest by Monday I pinged appropriate people in my team).
It could make sense to separate them out. We had some platforms where the death tests never fully worked ...
Yeah let's do it. Do you have time to tackle that? If not I might get around to it some point this weekend.
Sounds good. Also I send you an invite to our slack channel in case you are interested.
Note: I merged one other PR, but this one rebases cleanly on top of it.
Yeah this is great. Thanks so much!
I just noticed that this requires CXX Extensions for GCC. I.e. -std=gnu++14 - it doesn't work with -std=c++14. Do you consider that acceptable?
Its now fixed.
I do not see this working in 4.5.1 either (neither with View not with DynRankView), and I wouldn't have expected any change since the APU stuff wasn't changed in terms...