Christian Trott
Christian Trott
Wouldn't this thing do what you want (only posted the relevant parts)? ```c++ template struct pitched_accessor { int n_every; int extra_bytes; using data_handle_type = char*; pitched_accessor(int n_every_, int extra_bytes_) {...
That said, it looks like it does work with external Kokkos, so it seems it might be an internal cmake issue in Trilinos and or Kokkos?
Hm yeah if it was only Tpetra that might be the difference. I assumed it was the same configure with external Kokkos or internal.
Yeah definitely on the todo list. We got stuck with mdarray for a bit but I do want to revive it because I think it's just a huge usability improvement.
I don't think we care about testing this or? I assume Trilinos will complain if it breaks.
Exceptional rare is not a very nice argument if you want to run for a month on a million cores. Even if it would only fail every 100 million thread...
Why can't we just base something off the reference counting scheme of the new view implementation (which doesn't use a singleton scheme with centralized reference count objects)? That scheme is...
I will rebase this and merge my suggestions.
@oliverlee FYI: I rebased and force pushed. I'd like to get this in before I work on more of the features for C++26.
They passed now. We might have changed Debug to Release build at some point and so the rebase made them fail.