Christoph Stäbler

Results 102 comments of Christoph Stäbler

> @creydr In some places, it is failing because of the error, pod is not running > > ``` > wait.go:413: Pod test-inkspplu/source-ttdrjpyd is not running... > wait.go:413: Pod test-inkspplu/source-ffsjcstg...

Hey @Vishal-Chdhry, could you recheck on this? What do you think about having separate tests instead so you have `feature.T` available? Or any other ideas?

/remove-lifecycle stale Hi @vishal-chdhry, any plans to recheck on this, or do you want to close this PR?

``` wait.go:200: test-mbcwiubs/sinkbinding-qcvlukqo condition is {"type":"Ready","status":"False","lastTransitionTime":"2024-05-08T07:37:57Z","reason":"TrustBundlePropagation","message":"failed to create ConfigMap test-mbcwiubs/knative-eventing-bundlekne-bundle: configmaps \"knative-eventing-bundlekne-bundle\" already exists"} ``` /retest-required /cc @pierDipi

``` wait.go:200: test-xyfdvrfi/sinkbinding-fcpikzdn condition is {"type":"Ready","status":"False","lastTransitionTime":"2024-05-08T11:08:51Z","reason":"TrustBundlePropagation","message":"failed to create ConfigMap test-xyfdvrfi/knative-eventing-bundlekne-bundle: configmaps \"knative-eventing-bundlekne-bundle\" already exists"} ``` /retest-required

@pierDipi, we could also migrate the existing usages of `serviceAccountName` to `serviceAccountNames` for the other components too and then deprecate `serviceAccountName`. But we should do that in a separate PR.

> @creydr do we want to backport this to 1.14? If we do, maybe it would make sense to only have the CRD changes for the parallel and sequence in...

> @creydr I don't think this is strictly required nor needed I agree that this is not required, but keeps it IMO clearer.