Christoph Stäbler

Results 102 comments of Christoph Stäbler

Hello @AHB102, are you still working on this issue? Can we help you somehow on this?

Hello, as I haven't seen any contributions for this so far from I would clear the assignment to make it free for others again. In case anybody else wants to...

Hello @0ZeKa0, thanks a lot for your work on this. I commented on your PR. Btw: for the docs repo there is a preview generated too (e.g. https://deploy-preview-5993--knative.netlify.app/docs/eventing/brokers/broker-developer-config-options/ for your...

> This looks so cool!!!!! I see that conflicts have emerged over time, and I opened #1320 to see if we can get this across the finish line 🏁 Hey...

Hello @parth721, thanks for showing interest in this issue :+1: Anyhow, in case you're new to knative or the code base, I think a `good-first-issue` could be a good start...

@satyampsoni any updates on this? Do you need help with this?

> @creydr yep, How to fix this? ![image](https://private-user-images.githubusercontent.com/94950988/303596209-6566d44c-be3c-45da-820c-7d8685519ac1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDc0NzkyNTQsIm5iZiI6MTcwNzQ3ODk1NCwicGF0aCI6Ii85NDk1MDk4OC8zMDM1OTYyMDktNjU2NmQ0NGMtYmUzYy00NWRhLTgyMGMtN2Q4Njg1NTE5YWMxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAyMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMjA5VDExNDIzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM5ODIyNmEwNDU2ZDFiOTE5YzBiNGZkZDFjNzM4MGJlMjdjNTRmOTBlZWYwY2VjMmI2MGE4YjkyYmE4MTk3ZDkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.0c88RKcXkevOTSAZ4qMvspjAMRh_TdfoSWF9vSyh_Qk) This seems to be, as you simply return the given port to `StartServer()` in https://github.com/knative/eventing/pull/7607/files#diff-19e24bc260761850cf90ace03ff2291a969d7e008a6e555fb09d2728ee94fbd2R87. Anyhow you need to use the "real"...

Seen with other Tests too: - `TestChannelDeadLetterSink` * https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_eventing/7636/reconciler-tests_eventing_main/1752032564513607680 * https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_eventing/7636/reconciler-tests_eventing_main/1751886993832284160 * https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_eventing/7636/reconciler-tests_eventing_main/1751886993832284160 - `TestSmoke_SinkBinding` * https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_eventing/7527/reconciler-tests_eventing_main/1751054404775055360 * https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_eventing/7527/reconciler-tests_eventing_main/1751054404775055360 - `TestContainerSourceWithSinkURI` * https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_eventing/7527/reconciler-tests_eventing_main/1750981220394602496 - `TestSinkBindingV1Deployment_BrokerAsSinkTLS` * https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_eventing/7644/reconciler-tests_eventing_main/1752645343163453440