eventing
eventing copied to clipboard
Assert EventTypes references for IMC test
This is a follow-up to https://github.com/knative/eventing/pull/7888 All of the tests should be asserting the eventtype's reference.
Proposed Changes
- Assert eventtype reference for InMemoryChannel
- Remove TestContainerSourceEventTypeAutoCreate as automatic EventType creation for ContainerSource is not supported
Pre-review Checklist
- [ ] At least 80% unit test coverage
- [ ] E2E tests for any new behavior
- [ ] Docs PR for any user-facing impact
- [ ] Spec PR for any new API feature
- [ ] Conformance test for any change to the spec
Release Note
Docs
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 69.18%. Comparing base (
7e1c082
) to head (2da0d09
). Report is 37 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #7899 +/- ##
==========================================
- Coverage 69.22% 69.18% -0.04%
==========================================
Files 339 341 +2
Lines 19494 15816 -3678
==========================================
- Hits 13494 10943 -2551
+ Misses 5337 4200 -1137
- Partials 663 673 +10
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/hold
For experimental tests to pass
Looks like after fixing the test for ContainerSource, it shows that no EventTypes are automatically created. Checking on Slack to see if this is expected.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Cali0707, mgencur
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~test/OWNERS~~ [Cali0707]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
/test reconciler-tests
/test reconciler-tests
/test reconciler-tests
/unhold
/retest-required
/retest-required