eventing icon indicating copy to clipboard operation
eventing copied to clipboard

Assert EventTypes references for IMC test

Open mgencur opened this issue 9 months ago • 10 comments

This is a follow-up to https://github.com/knative/eventing/pull/7888 All of the tests should be asserting the eventtype's reference.

Proposed Changes

  • Assert eventtype reference for InMemoryChannel
  • Remove TestContainerSourceEventTypeAutoCreate as automatic EventType creation for ContainerSource is not supported

Pre-review Checklist

  • [ ] At least 80% unit test coverage
  • [ ] E2E tests for any new behavior
  • [ ] Docs PR for any user-facing impact
  • [ ] Spec PR for any new API feature
  • [ ] Conformance test for any change to the spec

Release Note


Docs

mgencur avatar May 07 '24 09:05 mgencur

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.18%. Comparing base (7e1c082) to head (2da0d09). Report is 37 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7899      +/-   ##
==========================================
- Coverage   69.22%   69.18%   -0.04%     
==========================================
  Files         339      341       +2     
  Lines       19494    15816    -3678     
==========================================
- Hits        13494    10943    -2551     
+ Misses       5337     4200    -1137     
- Partials      663      673      +10     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 07 '24 10:05 codecov[bot]

/hold

For experimental tests to pass

mgencur avatar May 07 '24 10:05 mgencur

Looks like after fixing the test for ContainerSource, it shows that no EventTypes are automatically created. Checking on Slack to see if this is expected.

mgencur avatar May 07 '24 12:05 mgencur

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar May 07 '24 17:05 knative-prow[bot]

/test reconciler-tests

pierDipi avatar May 08 '24 07:05 pierDipi

/test reconciler-tests

Cali0707 avatar May 08 '24 14:05 Cali0707

/test reconciler-tests

mgencur avatar May 09 '24 12:05 mgencur

/unhold

mgencur avatar May 09 '24 12:05 mgencur

/retest-required

Cali0707 avatar May 09 '24 18:05 Cali0707

/retest-required

creydr avatar May 10 '24 08:05 creydr