Christoph Stäbler

Results 100 comments of Christoph Stäbler

@Cali0707, on testing with `oidc-discovery-base-url: "https://oidc.eks.eu-west-1.amazonaws.com/id/1"`, I saw ``` Get \"https://oidc.eks.eu-west-1.amazonaws.com/id/1/.well-known/openid-configuration\": tls: failed to verify certificate: x509: certificate signed by unknown authority} ``` This was because the used HTTP client...

I can also check on https://github.com/knative/eventing/pull/8145#discussion_r1713221355 and get the features from the ctx in `auth.NewVerifier()`

> > I can also check on [#8145 (comment)](https://github.com/knative/eventing/pull/8145#discussion_r1713221355) and get the features from the ctx in `auth.NewVerifier()` > > Would this work if the features were updated to have...

@pierDipi As I also committed to this PR, could you give it a quick review from your side too?

JobSink does not come up ``` message: "{\"level\":\"info\",\"ts\":\"2024-10-05T16:42:12.130Z\",\"logger\":\"job-sink\",\"caller\":\"jobsink/main.go:112\",\"msg\":\"Starting the JobSink Ingress\",\"commit\":\"dcc5539\"}\npanic: runtime error: invalid memory address or nil pointer dereference\n[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x47f0d8]\n\ngoroutine 1 [running]:\nsync.(*RWMutex).Lock(0x21fd838?)\n\tsync/rwmutex.go:146 +0x18\nknative.dev/eventing/pkg/auth.(*Verifier).initOIDCProvider(0xc0003e2640, {0x21fd838,...

This issue makes definitely sense to me, especially as it seems users have issues on EKS...