eventing
eventing copied to clipboard
knative
Used Port 0 to fix issue #7393
Welcome @satyampsoni! It looks like this is your first PR to knative/eventing 🎉
![knative-prow[bot] avatar](https://avatars.githubusercontent.com/in/183726?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @satyampsoni. Thanks for your PR.
I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: satyampsoni Once this PR has been reviewed and has the lgtm label, please ask for approval from creydr. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@satyampsoni: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| unit-tests_eventing_main | 1e7aa11855800512b71eb557ec808ca751060a56 | link | true | /test unit-tests |
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@creydr yep, How to fix this?
This seems to be, as you simply return the given port to StartServer() in https://github.com/knative/eventing/pull/7607/files#diff-19e24bc260761850cf90ace03ff2291a969d7e008a6e555fb09d2728ee94fbd2R87. Anyhow you need to use the "real" port. Port 0 indicates simply to use the next available port.
When you start the server in receiver.StartListen(), you should be able to get the real port somehow.
Thanks for the help. Have looked into it. I'll correct it once my exams are over after 12 Feb.
