Michael Crenshaw

Copy or re-implement github.com/acomagu/bufpipe in go-git

1

github.com/acomagu/bufpipe triggers false-positives in license scanning tools such as FOSSA. The repo appears unmaintained, with the last commit being in June 2021. I'd suggest copying the code into this repo...

feat: use sync.Map instead of custom lock

1

`keyLock` just happens to fit one of the two recommended use cases for sync.Map: one where the map only grows. I understand this trades memory for less lock contention. I...

chore: deprecate trivial functions

1

These functions are trivial. Having them in this repo introduces more maintenance burden than maintaining implementations in the callers' repos. We should eventually remove these. https://github.com/argoproj/argo-cd/issues/22175

Questions about security vulnerability

4

Thanks for the quick follow-up to the recent [compromise](https://github.com/tj-actions/changed-files/issues/2464)! The hardening steps give me a lot of confidence that the same thing won't happen again. I have some additional questions:...

chore: remove unused Trunc function

1

Whatever it was used for before, it's no longer used for that.

Revert "Add option to skip the dryrun from the sync context (#708)"

2

I changed my mind and now think this is more of a hatchet solution than the scalpel we need to solve https://github.com/argoproj/argo-cd/issues/21788. Disabling dry runs entirely means you completely lose...

chore: update leads (max 2 per project)

21

I'm proposing to update our subproject leads to align with lead contribution [requirements](https://github.com/argoproj/argoproj/blob/695e89e25b7bd9284a4682399a5dcf4413f6a189/community/membership.md#lead) as well as the "two leads per project" [guideline](https://github.com/argoproj/argoproj/blob/695e89e25b7bd9284a4682399a5dcf4413f6a189/community/membership.md#appointment-of-subproject-leads). The proposed changes are: * Saravanan Balasubramanian: Workflows...