Revert "Add option to skip the dryrun from the sync context (#708)"

[crenshaw-dev]

I changed my mind and now think this is more of a hatchet solution than the scalpel we need to solve https://github.com/argoproj/argo-cd/issues/21788.

Disabling dry runs entirely means you completely lose validation indefinitely. That's an aggressive solution to a problem that likely only presents itself once in the lifecycle of an app.

Talked with @agaudreault, and we think we can solve the problem with a lighter touch.

This change hasn't been released in any Argo CD version yet, so it's safe to revert.

@alexmt since you merged the PR initially, lmk if you'd like to discuss further!

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 53.45%. Comparing base (8849c3f) to head (60e0d37). Report is 49 commits behind head on master.

Files with missing lines	Patch %	Lines
pkg/utils/kube/resource_ops.go	0.00%	2 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #730      +/-   ##
==========================================
- Coverage   54.26%   53.45%   -0.81%     
==========================================
  Files          64       64              
  Lines        6164     6549     +385     
==========================================
+ Hits         3345     3501     +156     
- Misses       2549     2771     +222     
- Partials      270      277       +7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sonarqubecloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[alexmt]

@crenshaw-dev If I was a user I don't think I would ever choose to have this sync option on resource level. However I totally can see how someone might want to sync app once with this option (via starting sync operation with sync option ). So I still think it was useful.