Michael Crenshaw
Michael Crenshaw
Proof-of-concept that will only work with Argo CD 2.6.0+ (or the current :latest build). It ends up looking like this, which is admittedly pretty bad. But that's just how the...
On mobile, the menu causes the page size to be too wide. Overflow isn't handled properly. https://github.com/argoproj/argo-site/assets/350466/500456e2-1e96-4065-887a-9636af4e5b52
This `replace` has been around for quite some time, and I don't think it's necessary any more: https://github.com/argoproj/argo-cd/pull/7744/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6 `go mod tidy` doesn't show a diff. @pasha-codefresh any concerns about removing...
Checklist: * [ ] Either (a) I've created an [enhancement proposal](https://github.com/argoproj/argo-cd/issues/new/choose) and discussed it with the community, (b) this is a bug fix, or (c) this does not need to...
Today the hydrator will re-run hydration even if the target dry SHA has already been hydrated. We should add logic to commit.go to read hydrator.metadata in the target branch (if...
A lot of error messages simply say "cache: key is missing". Including the cache key in the error message would help debug. https://github.com/argoproj/argo-cd/issues?q=is%3Aissue+is%3Aopen+%22cache%3A+key+is+missing%22
We use `grpc.Dial` in a lot of places, which [is an anti-pattern](https://github.com/grpc/grpc-go/blob/master/Documentation/anti-patterns.md). We should switch to `grpc.NewClient` as recommended by the library maintainers.
Codecov now has the ability to accept test results to track slow and/or flaky tests: https://app.codecov.io/gh/argoproj/argo-cd/tests/master The result upload is configured here: https://github.com/argoproj/argo-cd/blob/457bb1f23c3a30f18da1d322902715edcc8598e3/.github/workflows/ci-build.yaml#L382-L388 We currently only upload test results from...
Codecov now has the ability to accept test results to track slow and/or flaky tests: https://app.codecov.io/gh/argoproj/argo-cd/tests/master The result upload is configured here: https://github.com/argoproj/argo-cd/blob/457bb1f23c3a30f18da1d322902715edcc8598e3/.github/workflows/ci-build.yaml#L382-L388 We currently upload results only when the...
Full PR with all changes so I can run tests.