argo-cd icon indicating copy to clipboard operation
argo-cd copied to clipboard

feat: parameterized CMPs (#9135)

Open crenshaw-dev opened this issue 4 years ago • 2 comments

Closes #9135

crenshaw-dev avatar Apr 26 '22 13:04 crenshaw-dev

Not actually ready for review, I just want to see if it'll generate a codecov diff for me.

crenshaw-dev avatar Apr 27 '22 18:04 crenshaw-dev

Codecov Report

Base: 46.70% // Head: 46.88% // Increases project coverage by +0.17% :tada:

Coverage data is based on head (69367dc) compared to base (752bc5f). Patch coverage: 52.40% of modified lines in pull request are covered.

:exclamation: Current head 69367dc differs from pull request most recent head e6164cd. Consider uploading reports for the commit e6164cd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9216      +/-   ##
==========================================
+ Coverage   46.70%   46.88%   +0.17%     
==========================================
  Files         240      240              
  Lines       39771    39907     +136     
==========================================
+ Hits        18577    18712     +135     
+ Misses      19310    19303       -7     
- Partials     1884     1892       +8     
Impacted Files Coverage Δ
cmpserver/plugin/config.go 31.42% <ø> (ø)
util/app/discovery/discovery.go 41.07% <0.00%> (ø)
reposerver/repository/repository.go 59.83% <23.33%> (-1.64%) :arrow_down:
util/cmp/stream.go 50.94% <39.13%> (-0.04%) :arrow_down:
cmpserver/plugin/plugin.go 80.15% <67.53%> (+29.90%) :arrow_up:
pkg/apis/application/v1alpha1/types.go 58.18% <88.46%> (+0.76%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Apr 27 '22 18:04 codecov[bot]

@leoluz PTAL

crenshaw-dev avatar Nov 29 '22 16:11 crenshaw-dev