creesch
creesch
Just going over issues at the moment and wanted to note that: > I would suggest to use | as delimiter as it's seldom used in comments/posts. Probably isn't true...
Oh one additional thought, maybe the input should be retained as well? So that when you filter and then reopen the popup the current selection is visible?
Some of those are already available, just not documented all that well at times. > {permalink} Is already a thing. Also available is > {content} Also already a thing, in...
Seperate comment for the remaining two > `{link_flair_text}` This one I can see a use case for I suppose. I am not sure if it is something we can easily...
Just as a general note as I have been experimenting with this a bunch already, for old reddit specifically it takes a long time for the DOM to be even...
Something I noticed while profiling is that decompressing usernotes is a fairly intensive task. Which makes sense of course, for general performance on page it might help if we actually...
Ideally that would be the case however the logic can get complex certainly with bigger popups (and people with smaller windows/displays) you also don't want the popup header to fall...
> Note: PR done in the github web version of vscode so not actually tested yet. Tested and everything works as expected.
This should be ready to merge now: - On page load it will always attempt to fetch user details through the API. - When succeeded, it now actually does set...
And of course after I made this issue it appears to work normally. Something of note, it appears to me that if I have two browser windows open (not tabs,...