creesch

Results 222 comments of creesch

The word `more` is what you are missing ;)

> Subreddit or user-setting? Let's keep this a user setting. It allows for mods to have a slightly different personal flow. > Should shift be the modifier key? Probably >...

I really think we should keep this simple and a user setting to allow for a bit more personal flexibility as that seems to fit most use cases I can...

That could also work, either way this needs to be set separately for comments and posts otherwise the setting doesn't make much sense. Specifically considering the original use case this...

I think what eritbh is saying is that the current shift setting toggle would be replaced by a select option where people can select the behavior for holding shift. Do...

Started looking into this a little bit again. Caching does seem to be the biggest hurdle as far as I can tell. The way our caching is set up it...

Modqueue caching is a seperate mechanism, it uses a local map to store it's cache. This likely needs to be moved to an extension storage object.

Instead of refactoring all the cache related timeouts we might be able to leverage alarms - https://developer.chrome.com/docs/extensions/reference/alarms/ - https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/alarms - https://stackoverflow.com/questions/66391018/how-do-i-call-a-function-periodically-in-a-manifest-v3-chrome-extension Seems like it might be a good fit... but...

For some reason we still have a jquery ajax call in the background scripts https://github.com/toolbox-team/reddit-moderator-toolbox/blob/master/extension/data/background/handlers/notifications.js#L136 Needs to be replaced with a regular request.

Uh I suppose we could do that, but what is the use case if I may ask?