Guillaume J. Charmes

Results 69 comments of Guillaume J. Charmes

This would be better separated. Would you mind creating a `Dockerfile.java` or a subdirectory for this?

First, you need to check the port allocated (by doing docker inspect or simply docker ps, then you connect to your host's ip with the port you just found. If...

@namelus This is because Docker does NAT by default. When you do `-p 5900` docker will open a random port on the Docker VM and map it to 5900. 2...

I have no idea what a "port" is :) but for context, if you try to start a process in a PTY while not having access to the PTY, then...

This would be really nice indeed. A solution would be to do something similar as what the testify lib does and have a subset of testing.T like ``` // TestingT...

This doesn't do the trick on OSX. Volumes are working fine with other images like ubuntu. Virtualbox 5.1.22-11, Docker 17.06.0-ce, alpine 3.6.

I would be inclined to indeed set the flag by default, but it requires some exploration to make sure it doesn't break existing code bases. cc @kr, any thoughts on...

I'll try to take a look this week.

@mvdan, As @kr mentioned, closing the `tty` in the defer is quite intentional. If there is some unexpected behavior, it would be interesting to not discard the error (currently stamped...

Thank you for digging into this and for the snippet! I think your diagnostic is correct indeed. However, I am not sure I agree with > pty.Start should always, always...