Guillaume J. Charmes

Results 69 comments of Guillaume J. Charmes

I'll check on a mac as well. Note that from the snippet, replacing the KeepAlive with a `defer primary.Close()` also 'fixes' the issue as it would keep a reference to...

Random side note, looking into your package made me think of this, in case you are curious to see the most complete and awesome shell in go: https://github.com/creack/goshell :)

I did reproduce on OSX, and while I didn't find anything conclusive just yet, I am more and more thinking it is localized to the testing scenario and is unlikely...

I’ll take a look over the weekend. Quite a few tickets in backlog, sorry about that. On Thu, Jul 28, 2022 at 10:51 AM Pete Woods ***@***.***> wrote: > @CrEaK...

@jeffreystoke I apologize, I still have this in my todo list, will get to it when I can. @mattcanty This is quite a large change and I haven't find time...

I managed to try on windows, however, I couldn't get anything to work. Would you have a sample code that would demonstrate how to use this on windows? All my...

Would you mind adding an example for windows in the readme? Once merge, this PR will be gone and the links provided in the description forgotten.

nit: if you could push commits, it would make review easier. Keeping everything in one commit with force push is neat and tidy but makes it difficult to see what...

Sorry, didn't get time to dig into this yet. Something came to my attention though, no context, no detail but saw this: https://github.com/leokhoa/pty/commit/4fa3b1efb83b606140f0ffd5e6adde1745704931 As the lib would now panic if...

I still haven't had the time to dig into this, I am sorry. If someone could come up with an easy way to test it, it would be quite helpful...