Guillaume J. Charmes

Just tried the pty example from that repository, it doesn't even compile, which is quite bad as even if it is not supported, it shouldn't break compilation. I'll push a...

I just cloned the branch, it doesn't compile (go1.18) Getting: ``` # github.com/creack/pty .\cmd_windows.go:24:3: //go:linkname must refer to declared function or variable ```

In what situation do you have a fd without os.File? I had that situation when dealing with CGO, but it is quite specific and rare. As those `Size` functions can...

Thank you for the detail, but this seems like a very specific case, and I don't think it would justify a change in the public api / major version bump....

This is indeed a good use case. I don't think it is wide enough to warrant a breaking change in the api, but would an additional helper work for you?

Indeed, we do not support this os/arch yet. Unfortunately, I don't have any way to try. Would you be able to provide a live VM or SSH session so I...

@hmmftg is #144 enough or do you need actual support? Without any knowledge or mean of testing, I can't do much more at the time.

Note that you will need to update the dependency from github.com/kr/pty to github.com/creack/pty and use v1.1.18 (https://github.com/creack/pty/releases/tag/v1.1.18) to get the fix.

Having windows support would be great. PRs are welcome indeed :) On Thu, Apr 30, 2020 at 1:29 AM Edgar Lee wrote: > Windows 10 gained support for psuedo-terminals with...

@mardukbp unfortunatelly termtest/conpty is based on CGO, which is not an option here as it would be a breaking change. We could consider it for a v2 though. @virtuald This...