Tony Li

Results 46 comments of Tony Li

Just to make sure I understand the issue correctly, one test configuration can only accept one token as an environment variable, so this PR adds a couple more configurations, so...

> However, I worry it would end up taking a lot of CI time I don't think the build time would increase that much. The first `run_tests` does a clean...

@mokagio Thanks for taking the time to experiment with my suggestions. The CI env injection one looks really nice! πŸ‘

Hi @mokagio , do you think this PR is ready for review now?

Hi @jaclync , I'll merge this PR for now. I'm happy to follow up if you have any further comments. Thanks! πŸ˜„

θΏ”ε›žηš„η»“ζžœε°±ζ˜―εŽŸε›ΎοΌŒsize 可δ»₯用 (160, 160) 试试。

FYI, I've opened a PR here: https://github.com/xcpretty/xcode-install/pull/438

Since the bundler fix appears not working, I've converted this PR to a draft.

Thanks for the review, @mokagio . @jkmassel can probably talk about the grand plan. But in my understanding, yes, DI would be one of the end goals. I wasn't thinking...