woocommerce-ios
woocommerce-ios copied to clipboard
WIP – Xcode 14.0
Description
This is going to be a long running branch to (try to) stay on top of the Xcode 14 betas PRs.
I expected many of you will want to checkout this branch locally to play with it. As such, I think we should keep it alive by merging trunk
into it. But, I think once we'll officially switch to Xcode 14 stable, it'll make sense to do a big rebase so the history stays tidy.
I called the branch xcode-14
. This might give us the option to keep the beta branch stable (🙃 🙂) and work on a new beta support without breaking the "stable" branch. That is, we might have an xcode-14-beta-2
branch in the future.
Ideally, we should implement as many fixes for errors and warnings found here as possible on trunk
. See:
- #7057
Testing instructions
Download Xcode 14 beta 1 and run this branch 😅 .
If you do, you might notice a bunch of:
Cannot access property 'cancellableSiteID' with a non-sendable type 'AnyCancellable?' from non-isolated deinit; this is an error in Swift 6
I haven't looked into it yet, other than finding this thread about it in the Swift forums.
Screenshots
![]() |
![]() |
- [ ] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txt
if necessary.
You can test the changes from this Pull Request by:
- Clicking here or scanning the QR code below to access App Center
- Then installing the build number
pr7062-21de10c
on your iPhone
Hi @mokagio , do you think this PR is ready for review now?
Hi @mokagio , do you think this PR is ready for review now?
Yes it is! Pushing the button and reaching out to the devs.
Hi @jaclync , I'll merge this PR for now. I'm happy to follow up if you have any further comments. Thanks! 😄