Tony Li

Results 46 comments of Tony Li

@getaaron I've address the review comments in https://github.com/fastlane/fastlane/pull/20537/commits/6c5d2b916956f20ea76aadcfdffc70c2ed0464f4

The test failures on this PR is a bit strange... UI tests on iPhone and iPad pass on my own mac, whereas they fail reliably on CI. Unit tests fail...

Similar to https://github.com/wordpress-mobile/WordPress-iOS/pull/19119, I'll summarize the status of UI and unit tests. I'll come back once next beta is out. - Two unit tests fail on CI: * one failure...

> the other is also formatter related. "lbs" isn't translated to localized "磅" in Chinese This issue is fixed in beta 5.

@oguzkocer No problem. Thanks for the reminder. I should've removed the milestone when I turned this PR to draft.

> the other is also formatter related. "lbs" isn't translated to localized "磅" in Chinese This issue is fixed in Xcode 14 beta 6. Given Apple is about to release...

Hi @mokagio , this PR is ready for review. Thanks!

@mokagio Thanks for getting the flaky test passed. https://github.com/woocommerce/woocommerce-ios/pull/7719 should fix this flaky test. 🤞

Hi @iamgabrielma and @jaclync , I thought I'll let you all know about this issue, since you both worked on this screen recently. This might just be an issue in...

@itsmeichigo I just checked on the trunk branch, this Xcode 14 issue still happens on an iOS 16 simulator. But with [this workaround for iOS 16](https://github.com/woocommerce/woocommerce-ios/pull/7371/commits/30df0bb4b78318f6df1c6e75ebed1a2a7ac26040), this issue no longer...