WordPress-iOS icon indicating copy to clipboard operation
WordPress-iOS copied to clipboard

Published 20 hours ago • verified publisher icon wordpress-mobile

The bundler workaround is not needed when using xcode-14 CI image

Open crazytonyli opened this issue 2 years ago • 3 comments

Resolves https://github.com/Automattic/bash-cache-buildkite-plugin/issues/16

This PR is good to merge if CI jobs pass.

Regression Notes

  1. Potential unintended areas of impact None.

  2. What I did to test those areas of impact (or what existing automated tests I relied on) None.

  3. What automated tests I added (or what prevented me from doing so) None.

PR submission checklist:

  • [x] I have completed the Regression Notes.
  • [x] I have considered adding unit tests for my changes.
  • [x] I have considered adding accessibility improvements for my changes.
  • [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

crazytonyli avatar Sep 15 '22 02:09 crazytonyli

Warnings
:warning: This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by :no_entry_sign: dangerJS

peril-wordpress-mobile[bot] avatar Sep 15 '22 21:09 peril-wordpress-mobile[bot]

Since the bundler fix appears not working, I've converted this PR to a draft.

crazytonyli avatar Sep 15 '22 22:09 crazytonyli

@crazytonyli I based https://github.com/wordpress-mobile/WordPress-iOS/pull/19323 on top of your work here and the fact that the gem install bundler workaround is now part of the bash-cache plugin.

CI there is green.

If you like what you're seeing in that PR, I think we should close this one in favor of it.

mokagio avatar Sep 19 '22 06:09 mokagio