Daniel McCarney

Results 647 comments of Daniel McCarney

The issues with the `Codec` return were addressed, and Rustls 0.21.0 has support for IP address subjects in certificates. I'm going to close this ticket since I believe the associated...

I'm going to close this draft PR since it's quite out of date with `main` and doesn't seem like a high priority to fix. I suspect some of the issues...

I think we should close this PR to reflect that it is: i. Not under active development by anyone at this time ii. Has substantial conflicts with `main` iii. Is...

> This doesn't feel like a big win by itself... For one PR in isolation it's not a huge win, but as more of them enter into this state the...

@daladim Did you have a chance to take the advice Djc described above? I think we're likely to close this issue unless you can provide more reproduction information.

Closing based on missing reproduction info and no reply from the OP back in march.

> This PR can remain for doing it in the more reasonable way: so please add a git revert 5288fcf to the top. I think we should close this PR...

My read of this discussion is we believe the parts required are already present. I'm going to close this issue until the original poster can reply to djc's question about...

Is there a way to tighten the visibility of `ClientSessionCommon.rewind_epoch`: https://github.com/rustls/rustls/blob/d8f04295baa990b0d7168dfdac09c228a5dca2c5/rustls/src/msgs/persist.rs#L230-L234 (I think only used from the bogo shim). I could be off track but if the type becomes public...

> yeah afaict the only reason ClientSessionCommon is pub is so bogo_shim can call rewind_epoch on it, and the Deref doesn't work there because it needs mutation. how about instead:...