Daniel McCarney

Results 647 comments of Daniel McCarney

I think we can close this based on https://github.com/rustls/rustls/pull/1568 and associated in progress work.

With Rustls 0.21.0 there is now support for IP address subjects in certificates. I think we should close this issue and if there are remaining gaps it would be best...

This looks like another issue where we can't make progress from the rustls side unless Ring adds support, or we land alternative backend support as described in https://github.com/rustls/rustls/pull/1184 I'm going...

This looks like it was fixed with https://github.com/rustls/rustls/commit/a777077257b4898c996b5e8a641219330d8a7a7a

Since #942 landed I think we can close this. There may be further improvements to be made but I think this issue's scope was the API docs and this type...

> There are other cases where this wasn't done. WebPKIVerifier is the one I remember off the top of my head. This looks resolved in `main`: we have `WebPkiClientVerifier` and...

I've done a pass in https://github.com/rustls/rustls/pull/1543 that I think caught the remaining instances. > I would close it if the clippy lints for this are being enforced in CI @briansmith...

> I suggest we close this. Agreed :+1:

It looks like #939 landed. I'm going to close this issue but if there's any remaining confusion we can revisit. Thanks!

I think since this branch is blocked on work happening in Ring, and the relevant issue (https://github.com/briansmith/ring/issues/1227) hasn't had updates in ~2 years we should close this branch for now...