Christoph Nakazawa comments

Results 189 comments of


                                            Christoph Nakazawa

fix: normalize path separator for rootDir replacement

What's the status of this PR?

Bug: ESLint react-hooks/rules-of-hooks false positives when codepath counts exceed Number.MAX_SAFE_INTEGER

I'm running into the exact same issue, also with optional chaining in a large component.

Statements and Branches never get to 100% coverage

Jest uses istanbul on transformed code though, so it should cover those babel helpers as well?

[discussion] supporting platform-specific Babel plugins

Do you wanna work on a PR for this? :)

Make v8 coverage the default, get rid of babel-plugin-istanbul.

I just rebased this to pass all the tests. In general, you are right and we should consider changing defaults first. I thought deeply about proposing this PR as is,...

Make v8 coverage the default, get rid of babel-plugin-istanbul.

> I'd recommend to link this PR in the changelog.md and also also add a short description why the change has been done since it is not listed in the...

Make v8 coverage the default, get rid of babel-plugin-istanbul.

I'm pretty sure I removed like 99% of the code. The remaining use of Istanbul's libraries is for coverage reporting, which is used for printing the v8 coverage results.

Make v8 coverage the default, get rid of babel-plugin-istanbul.

Thanks so much @Smrtnyk. We are currently collecting data on the expected differences to make a decision on this PR. Any chance you could run both coverage modes and share...

feat: [iOS] add caretHeight and caretYoffset to TextInput component

@sammy-SC @yungsters could you merge this?

Find Identifiers that are not part of a MemberExpression

Property names in ObjectExpressions: ``` js {a: b} // don't rename a {a} // rename a ```