react-native
react-native copied to clipboard
feat: [iOS] add caretHeight and caretYoffset to TextInput component
Summary:
This PR adds support for the caret height and caret position properties in iOS multi-line TextInput PR for the docs update: https://github.com/facebook/react-native-website/pull/3709
Changelog:
[IOS] [ADDED] - Add caretHeight
and caretYOffset
props to TextInput component
Test Plan:
Default caret:
https://user-images.githubusercontent.com/19835085/236169989-54ddf4f7-6606-4b1c-b615-dab64fb2d948.mov
Caret with caretHeight
and caretYOffset
adjustment:
https://user-images.githubusercontent.com/19835085/236170124-82b915ae-304e-426a-ba91-851c20954c7a.mov
Hi @OlimpiaZurek!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed
. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Platform | Engine | Arch | Size (bytes) | Diff |
---|---|---|---|---|
android | hermes | arm64-v8a | 18,000,725 | +118,595 |
android | hermes | armeabi-v7a | n/a | -- |
android | hermes | x86 | n/a | -- |
android | hermes | x86_64 | n/a | -- |
android | jsc | arm64-v8a | 21,359,082 | +118,511 |
android | jsc | armeabi-v7a | n/a | -- |
android | jsc | x86 | n/a | -- |
android | jsc | x86_64 | n/a | -- |
Base commit: 12f2c3cd2bbf186afe1b4052ebf377d8030c7a73 Branch: main
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
All comments have already been resolved. Can someone take another look and review? Thanks!
Conflicts resolved, ready for review
Hey @fabioh8010 - would it be possible to add this PR to your list of priorities? It's one of our oldest outstanding bugs and we'd love to get it resolved. Thanks!
Hi @sakluger , I don't work at Meta, I just reviewed because I'm from the same company of the PR author.
@sammy-SC @yungsters could you merge this?
@sammy-SC All comments have been resolved. Can you take a look and review ? Thanks! cc: @NickGerleman
LGTM, few comments.