Christoph Nakazawa comments

Results 187 comments of


                                            Christoph Nakazawa

[Bug]: Snapshot tests failing for React 19

Could somebody send a PR like it was suggested above to use react-is v19, but have a symbol fallback check for React pre v19?

feat: forward runtime error logs to server

Some thoughts: * How about `forwardClientLogs` since runtime is ambiguous (what runtime, the vite runtime, or the runtime that is using Vite-compiled bundles, or .. just the app code?) *...

feat: forward runtime error logs to server

I recommend against using `browser`. Vite doesn't have to target a browser environment. `forwardConsole` might work.

Rules are difficult to use togehter with nextjs config.

What exactly were the problems you ran into?

Rules are difficult to use togehter with nextjs config.

Closing due to inactivity, happy to make changes if necessary.

Rules are difficult to use togehter with nextjs config.

Ah I see, I think once Next upgrades to ESLint v9 it should work fine.

Add failing test for `request for ... is not yet fulfilled`

Is this still relevant?

Governance

I think it is indeed important that we get this right but I'd prefer to hold off on implementing such a system until we have grown contributors and until the...

Governance

I made some adjustments to the teams to reflect the current state and turned the core group visible.

Possible memory leak – Window object retains after window.close()

@domenic now that the holidays are over, is this something you could investigate and possibly fix?