Christoph Nakazawa

Results 187 comments of Christoph Nakazawa

The Facebook GitHub org only contains project managed by Facebook. It'll mean we have to take care of releases and everything. I'm not sure if that's a good idea, you'll...

Yes this does suck indeed. The manual mocking system is really not good and I'm happy to accept PRs that will improve the situation, assuming we can make sure we...

Yes, mocks are "global" as well. This is a terrible design that we have to live with, unfortunately. At FB we have 4000+ mock files in the wrong location (and...

Yeah, it should be a config option. But I'm not just talking about the warning, I'm also talking about the feature in general.

The resolution code is called from jest-runtime: https://github.com/facebook/jest/blob/master/packages/jest-runtime/src/index.js and is somewhere in jest-resolve and jest-resolve-dependencies.

Hey everyone, sorry for the delay, I'm pretty backed up with a ton of stuff right now. I think I'm fine if you guys decide to do whatever breaking change...

Let's keep this focused on changing how haste works (whitelist/blacklist rather than on by default). I do think I'd prefer to maintain that `/__mocks__` should be the default for node...

I think these are some larger changes on the way to get this resolved but I think we need both the singular globalMocks option (could be a string or array...

The way to solve this is by adding a side-effectful module that you import before any other modules in your worker. See [`initializeWorker.tsx`](https://github.com/nkzw-tech/athena-crisis/commit/637fdcd70f8d87af2b2c497a339e62df18877afd#diff-ba3bff0d1de85b2cfa7492e65677e518a279330af50c270296aafb689ab736b7) and [the example usage in a worker](https://github.com/nkzw-tech/athena-crisis/commit/637fdcd70f8d87af2b2c497a339e62df18877afd#diff-7f5232aa1170e2f9c713072b270e4bf94fee631d10f4f03e7b39a0cf7be93717R1).

I was asked whether I would be happy to contribute this change, but instead I'd be happy to pay $100 to whoever fixes this in a satisfying way and shaving...