Éric Dupuis

Results 95 comments of Éric Dupuis

@yrouranos I couldn't find a GitHub project named as `scen_workflow_afr`, could you give me a link to the repo?

> Feel free to merge when ready! Thanks again! Did you do something? I only re-ran the tests. Whatever works haha.

> This is some really interesting work by @coxipi ... I thought it might want a good look by a few people so have tagged multiple reviewers. @coxipi not 100%...

> Et en terme de performance, qu'est-ce que ça dit? C'est surtout l'utilisation de la mémoire qui est beaucoup plus efficace. Le nouvel algorithme ne nécessite pas d'avoir un seul...

J'utilise le repo `scen_workflow_afr`, l'implémentation de ces indices est plus à jour. Pas de problème pour fermer ça je pense bien, mais c'est plus Yannick qui saurait s'il reste du...

Hi @lukruh, indeed, the support for log-logistic should be quite straightforward to add. You're welcome to submit a PR for this. Please check the documentation on how to create new...

@tlogan2000 @RondeauG: I was discussing this with @aulemahal: The parameter `resample_before_rl` (see above "What kind of change does this PR introduce?" for more info on this parameter) is implemented similarly...

> @coxipi I was forced to remove the changes you made to `freshet_start` as this PR is deprecating that indice. If you'd like to add your `run_length` changes to `first_day_temperature_{above...

> @coxipi I was forced to remove the changes you made to `freshet_start` as this PR is deprecating that indice. If you'd like to add your `run_length` changes to `first_day_temperature_{above...