Éric Dupuis
Éric Dupuis
@SarahG-579462 : As I understand, I should simply remove the %%timeit tests in the notebook as they don't make sense with Abel's function, correct? Also, I should set cache to...
> A few nitpicks from me but otherwise it looks good ! Also don't forget to remove, move elsewhere the notebooks before merging Thanks! One notebook was not intended indeed,...
The present implementation is not right, the call to `nan_quantile` is not properly "jitterized". Among other things, some operations in nan_quantile use the argument `axis` in `nan_quantile` which is unsupported...
Should be good to go, I added a few tests
> Would it be possible for you to add fastnanquantile as a dependency that can be installed via tox (e.g. under deps: fastnanquantile: fastnanquantile) and add that to one of...
@SarahG-579462 can you inspect a last time? Should be good now
Hi @DamienIrving , thanks for the suggestion. I also agree that the idea of using `sim_q` seems similar to QDM. Looking specifically at sec.3.2 of [Anandh et al 2011](https://doi.org/10.1029/2010WR009104), I...
@DamienIrving Yes, that's clear. I didn't read the paper properly at first. As I understand now, the CF (here `af`) factors found in the training are to be used as-is...
> that's what @coxipi showed with his synthetic examples of g Sorry, I removed the post with synthetic $g$ since I thought there was maybe an error, but anyways, I...
Hi! > The reference and historical datasets are made of a single chunk of size 7305 for the time coordinate. Are you sure? That doesn't seem to be the case...