Éric Dupuis
Éric Dupuis
Once tests pass here, I will merge
Btw, I don't know why the tests fail here on GH, on my machine it's fine, I need to check what is going on
> These changes shouldn't be needed. I thought I had removed this, thanks
yes, we were speaking of triggering tests too often. Removing an inconsequential white space should not need to run new tests, but drawing the line automatically is probably complicated
> You can skip running the tests by prepending [skip ci] or [no ci] to your commit message, but we often don't do that. I'll try this next time, nice
Very nice! The code is very readable, well organized, good job! In one of my comment where I mention a possible function `_otc_adjust`, you can also see I mention `map_blocks`....
This might help you: ``xclim.indices.helpers.cosine_of_solar_zenith_angle`` ? The case with `sunlit=True`?
```python # cosine_of_solar_zenith_angle if sunlit: # hour angle of sunset (eq. 2.15), with NaNs inside the polar day/night tantan = -np.tan(lat) * np.tan(declination) h_ss = np.arccos(tantan.where(abs(tantan)
Hi! Thanks for this report and the inclusion of your data, it's very helpful for troubleshooting. I'm unsure if this is type of behaviour is expected since your datasets are...
I think @RondeauG has given an appropriate answer, so I will be closing the issue unless you have something to add @bweeding?