Cornelius Schumacher
Cornelius Schumacher
I tend to agree with @scravy that "normalizing" the code regarding formatting for the merge will make merging easier. I also see it as pretty much the only way to...
One thing we probably would need to do when merging branches formatted with clang-format is to use the `ignore-all-space` option as in `git merge -Xignore-all-space master` to avoid conflicts due...
I have to agree with @kostyantyn. If a pull request breaks the tests because of a problem with updates in the master branch which don't cause merge conflicts, the CI...
Validators could always also act as proposers to state their preferences, couldn't they? Or should they be differently weighted?
Having a script helping with merges and including things like the ACKs might be helpful, but I'm not sure it solves the problem of reviewing the commit message. The description...
In the blog they say that the issue is considered low risk because the scenario of running on a computer where other users have access as well is discouraged in...
Some more info: * There is an attempt to build Bitcoin with cmake which kind of seems to work, at least for Linux : https://github.com/bitcoin/bitcoin/compare/master...nightsuns:master * Bitcoin Cash also builds...
GitHub has a little bit of documentation including generating keys: https://help.github.com/en/articles/signing-commits. This is not very extensive but quite some people probably use this documentation because of the popularity of GitHub....
> I'm very much in favour of signing our commits (I already started doing it 😄 ). The problem is that it doesn't work well with the workflow of squashing...
I think adding the dependency in the container so that it builds again is fine. We can leave further steps for later. If it would improve security to add it...