unit-e icon indicating copy to clipboard operation
unit-e copied to clipboard
verified publisher icon dtr-org

move to cmake

Open scravy opened this issue 7 years ago • 5 comments

Let's discuss if it's worth it.

scravy avatar Sep 04 '18 13:09 scravy

cmake is kind of a standard now, I can't estimate the effort but if we could migrate, it would be brilliant and we could use Clion to build unit-e :)

kostyantyn avatar Sep 04 '18 13:09 kostyantyn

I've never heard regret about cmake

amiller avatar Sep 04 '18 14:09 amiller

Would be welcome @ bitcoin too apparently: https://github.com/bitcoin/bitcoin/issues/14124#issuecomment-418719500

scravy avatar Sep 06 '18 12:09 scravy

Some more info:

  • There is an attempt to build Bitcoin with cmake which kind of seems to work, at least for Linux : https://github.com/bitcoin/bitcoin/compare/master...nightsuns:master
  • Bitcoin Cash also builds with cmake: https://github.com/Bitcoin-ABC/bitcoin-abc/tree/master/cmake
  • Some hints from StackOverflow about porting from automake to cmake: https://stackoverflow.com/questions/7132862/tutorial-for-converting-autotools-to-cmake
  • A script to convert from automake to cmake (probably to specific to KDE to be useful): https://cgit.kde.org/kde-dev-scripts.git/tree/cmake-utils/scripts/am2cmake

cornelius avatar Oct 11 '18 13:10 cornelius

As brought up in #326 and also documented in this stackoverflow question and uncvoered in this CLion ticket there are real problems with the current autotools setup. Another reason to get cmake going.

Nota bene: The stackoverflow question only mentions os x, but the jetbrains support guy also managed to reproduce on linux, so it definitely is a build system culprit.

scravy avatar Dec 03 '18 11:12 scravy