rust
rust copied to clipboard
rust-lang
Update Windows platform support
This should not be merged until Rust 1.76 but I'm told this may need an fcp in addition to MCP 651.
cc @rust-lang/compiler @rust-lang/release
Similarly to https://github.com/rust-lang/rust/pull/104385#issuecomment-1686512864, should this be a T-libs + T-compiler FCP, rather than T-compiler + T-release? I don't actually think we have a policy around bumping minimum support.
The current target policy says:
Raising the baseline expectations of a tier 1 target (such as the minimum CPU features or OS version required) requires the approval of the compiler and release teams, and should be widely communicated as well, but does not necessarily require a full RFC.
(I'm not opposed to including T-libs, just quoting what we have.)
:umbrella: The latest upstream changes (presumably #104385) made this pull request unmergeable. Please resolve the merge conflicts.
Team member @compiler-errors has proposed to merge this. The next step is review by the rest of the tagged team members:
- [x] @Aaron1011
- [x] @Dylan-DPC
- [x] @Mark-Simulacrum
- [x] @cjgillot
- [x] @compiler-errors
- [x] @cuviper
- [x] @davidtwco
- [x] @eddyb
- [ ] @estebank
- [x] @jackh726
- [x] @lcnr
- [x] @matthewjasper
- [x] @michaelwoerister
- [x] @nagisa
- [x] @oli-obk
- [x] @petrochenkov
- [x] @pietroalbini
- [x] @pnkfelix
- [x] @tmandry
- [x] @wesleywiser
Concerns:
- ~~needs-blog-post~~ resolved by https://github.com/rust-lang/rust/pull/115141#issuecomment-1966244246
Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!
See this document for info about what commands tagged team members can give me.
needs-blog-post
Just to note, the intent to update Windows compatibility was announced in the Rust 1.72.0 blog post, which was a light release so there was some discussion.
I think this PR should be merged with (and backport to) the 1.76 release this week to avoid confusion like the MIPS demotion. (edit: since there's actually no concrete change and the target can still work on Windows 7, waiting for the next release seems also fine.)
A blog post is being prepared if anyone has any final comments. I don't know if anyone has any thoughts on post date for the blog. I'm thinking soon.
As noted by @dpaoliello, we don't officially support XP even at tier 3 so I've also removed that. Of course no_std XP may work but it's not special in that regard. People have managed to compile Rust programs for old Windows versions at least as far back as Win95, which is great but not something that the Rust project currently supports in an official capacity.
@Aaron1011, @estebank or @pnkfelix would you mind checking your box or leaving a concern on this FCP?
Thanks! 🙂
:umbrella: The latest upstream changes (presumably #121998) made this pull request unmergeable. Please resolve the merge conflicts.
The final comment period, with a disposition to merge, as per the review above, is now complete.
As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.
This will be merged soon.
:umbrella: The latest upstream changes (presumably #122305) made this pull request unmergeable. Please resolve the merge conflicts.
FYI, I used the Windows targets as examples when filling out the description field in the targets, so you'll need to update the text there to: https://github.com/rust-lang/rust/commit/d6b597b786fad6e726fe458bb329959979a0e239
I think I sneaked that in before your comment, no?
Ah, you did, my bad for not checking the files...
I probably should have made a new commit. But I am a fan of having a clean commit history 😁