Callum Waters

Could we agree on the design and upstream it for you? Or what is the timeline for this?

> Side note: how do you guys plan on handling sync from genesis if gas is different? It will need to be versioned somehow. At the moment this is done...

I think we calculate the space taken by the blobs incorrectly https://github.com/celestiaorg/celestia-app/blob/2d261a2a0f7f627044342929b534a16b762c47e0/x/blob/ante/max_total_blob_size_ante.go#L74-L79 it should be in regards of the amount of shares * 512 bytes i.e. ```go for _, size...

> getTotal is only used [here](https://github.com/celestiaorg/celestia-app/blob/2d261a2a0f7f627044342929b534a16b762c47e0/x/blob/ante/max_total_blob_size_ante.go#L33) where we want the number of total bytes in the blob sizes. yes but we want the total bytes based on the amount of...

Furthermore, we may look to remove the `Get` and `GetWithProof` methods.

> Not sure. Counter arguments: if the hashing of the leaves is left to the caller, the tree becomes more difficult to be used correctly (e.g. no domain separation between...

> Maybe we should add the fact that you need versioning for the CreateCommitment function. As we might be adding other things in the future which will change the shares...

@jcstein all comments should be resolved now

> Looks like markdownlint is failing [here](https://github.com/celestiaorg/CIPs/actions/runs/8451970766/job/23151391813?pr=115#step:5:5). Is the plan to hold off on merging this until the Lemongrass hardfork executes on mainnet? My impression was that all these CIPs...

I'll port my upgrades change to the v0.46 branch and then I think we can deprecate it