docs(cip-13): add NetworkMinGasPrice to params list

[ninabarbakadze]

Overview

• Fixes #113

[rootulp]

Looks like markdownlint is failing here. Is the plan to hold off on merging this until the Lemongrass hardfork executes on mainnet?

[ninabarbakadze]

Looks like markdownlint is failing here. Is the plan to hold off on merging this until the Lemongrass hardfork executes on mainnet?

waiting till lemongrass is executed seems reasonable to me. should i convert this into a draft till then?

[rootulp]

should i convert this into a draft till then?

Sounds good to me. That way we don't accidentally merge it early.

[cmwaters]

Looks like markdownlint is failing here. Is the plan to hold off on merging this until the Lemongrass hardfork executes on mainnet?

My impression was that all these CIPs should be finalized before the lemongrass hardfork is finalized hence this PR should be merge ASAP

Finalizing does not mean implemented nor in production just that the design has been agreed upon

[rootulp]

This PR doesn't change anything about the design. It adds a param to the living document of params in CIP-13. IMO we don't need to merge this PR ASAP because Lemongrass is still months away.

If you want to merge this PR ASAP, then I propose adding versions to the relevant params in CIP-13 and then we can merge a modified version of this PR that states GlobalMinGasPrice is only relevant to app version 2.

[ninabarbakadze]

Overview

• Fixes Update CIP-13 to add minfee.GlobalMinGasPrice #113

I updated the definition and the value to latest. @rootulp @cmwaters

Should we merge? @YazzyYaz @jcstein

[rootulp]

IMO we shouldn't merge b/c then the params in this table don't reflect what is on mainnet. I think the intention of this table is that it's a living document of what is on mainnet. If we want to preserve that, we could have two tables like what is done here:

1. https://celestiaorg.github.io/celestia-app/specs/parameters_v1.html
2. https://celestiaorg.github.io/celestia-app/specs/parameters_v2.html

Or we wait until v2.0.0 gets deployed on mainnet

[jcstein]

I'll mark as draft again as to prevent an accidental early merge :)

[rootulp]

[tangent] I think it's going to be a slight maintenance burden to keep this document up to date with what is on mainnet. We already have: https://celestiaorg.github.io/celestia-app/specs/parameters.html so I don't see CIP-13 adding much value.

[jcstein]

Do the parameters update based on what is on mainnet already? https://celestiaorg.github.io/celestia-app/specs/parameters.html

[rootulp]

Nope that's manually updated. I'm trying to minimize the number of places we need to update b/c I think it could lead to inconsistencies.

Also the source of truth is the params actually on mainnet so we could generate a site that queries the params from a mainnet node and displays them.

[jcstein]

I'm trying to minimize the number of places we need to update b/c I think it could lead to inconsistencies.

seems like a safe idea. I wonder if maybe we can turn this CIP into one that lives on the site somehow...similarly to how, for example, https://celestia.cool pulls latest mempool info from a consensus endpoint