Callum Waters comments

Results 248 comments of


                                            Callum Waters

Add a metric to track state size

I think it would be helpful to also know the depth of the tree, that way we can make some inference of lookup times

Only use CAT pool in e2e tests

Agree. We should have tests for all implementations that we support

Don't assume that all transaction reaped from the mempool will be accepted by the application

We could track as a metric how many transactions are rejected by the application

I've worked on this prototype (https://github.com/celestiaorg/celestia-core/pull/1342) to illustrate using a model based approach to having dynamic timeouts which I think would be the simplest as most effective solution to stable...

Remove share and row proof logic

Yeah this makes total sense

Unbounded blocksize network test

I think it's pretty important that any performance-based testing simulates as close as possible to what we expect the network to be i.e. if we think the network will have...

Implement a blobless block endpoint

This seems a duplicate of https://github.com/celestiaorg/celestia-core/issues/1121 (or the other way around)

Too small `MaxGossipDelay` results in disconnecting from all peers in testground

So just from looking at the code, there doesn't seem to be any path which would cause the node to disconnect with their peer. There are three places that this...

feat: change cat channel priorities

Yeah let me put this in draft for now so we can experiment on it

Callum Waters