CIPs icon indicating copy to clipboard operation
CIPs copied to clipboard

CIP to introduce authored blobs

Open cmwaters opened this issue 1 year ago • 2 comments

This CIP is in reference to this issue: https://github.com/celestiaorg/celestia-app/issues/3316

Note that there is a diagram so when changing the name of the file and folders, make sure to change the name of the folder in the assets directory and update this CIP that references it

cmwaters avatar May 22 '24 10:05 cmwaters

Maybe we should add the fact that you need versioning for the CreateCommitment function. As we might be adding other things in the future which will change the shares and therefore the share commitment.

Create commitment will now have to be aware of the signer.

nashqueue avatar May 22 '24 14:05 nashqueue

Maybe we should add the fact that you need versioning for the CreateCommitment function. As we might be adding other things in the future which will change the shares and therefore the share commitment.

Create commitment will now have to be aware of the signer.

The CreateCommitment function has the following signature:

func CreateCommitment(blob *blob.Blob, merkleRootFn MerkleRootFn, subtreeRootThreshold int) ([]byte, error) 

As it includes the blob, which has the signer as well as the share version, I don't think anything will need to change to the function signature. Of course within the function, the commitment construction will depend on whether the signer is present in the blob or not

cmwaters avatar May 23 '24 10:05 cmwaters

@jcstein all comments should be resolved now

cmwaters avatar Jun 03 '24 10:06 cmwaters

Assigned this CIP-21. FYI @jcstein

rootulp avatar Jun 04 '24 15:06 rootulp